Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix publish #95

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: fix publish #95

merged 1 commit into from
Oct 12, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Oct 12, 2022

Splits the release-please workflow into 2 jobs, first the tests that run with all nodejs versions. IF that is successful then release-please is run once

See also #94 (comment)

@danez danez marked this pull request as ready for review October 12, 2022 11:50
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #95 (1b53db6) into main (882b023) will decrease coverage by 2.56%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   93.06%   90.50%   -2.57%     
==========================================
  Files           9        9              
  Lines         173      179       +6     
==========================================
+ Hits          161      162       +1     
- Misses         12       17       +5     
Impacted Files Coverage Δ
lib/wait-port.js 85.96% <28.57%> (-3.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dwmkerr
Copy link
Owner

dwmkerr commented Oct 12, 2022

Thanks @danez didn't realise I hadn't fixed this (I've been putting a skeleton based on this project into https://github.com/dwmkerr/template-nodejs-module/ which splits up the workflow just like you've done here)

@dwmkerr dwmkerr merged commit 446798a into dwmkerr:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants