Bug when grouping with more than one variable

[svkohler]

Example:

When compiling this:

coefficients as (

    select * from {{
      dbt_linreg.ols(
        table='kunde_umsatz_pre_and_post',
        endog='Umsatz',
        exog=['VarianteID', 'Umsatzvorperiode'],
        group_by=['TrancheID', 'MandantID'],
        format='long',
        format_options={'round': 5},
      )
    }}

)

one gets following, see how there is a missing leading whitespace in front of the "and" keyword of the join condition:

(...)
inner join _dbt_linreg_stderrs
on
  b.gb1 = _dbt_linreg_stderrs.gb1and
  b.gb2 = _dbt_linreg_stderrs.gb2
union all
select
  
  b.gb1 as TrancheID,
  b.gb2 as MandantID,
  'Umsatzvorperiode' as variable_name,
  round(x2_coef, 5) as coefficient,
  round(x2_stderr, 5) as standard_error,
  round(x2_coef/x2_stderr, 5) as t_statistic
from _dbt_linreg_final_coefs as b

inner join _dbt_linreg_stderrs
on
  b.gb1 = _dbt_linreg_stderrs.gb1and
  b.gb2 = _dbt_linreg_stderrs.gb2)

One can fix this easily by modifying line 224 of utils.py from:

{%- if not loop.last -%}

to:

 {% if not loop.last -%}

[dwreeves]

Ahhh! Sorry about that. Good catch on this. 🤦 Should be a quick fix. I'll have a new prerelease version out in the next hour.

Thanks for reporting this issue and for using this library!

[dwreeves]

@svkohler Thanks again for the report. Updating to the latest version, 0.2.6, will fix the issue:

packages:
  - package: "dwreeves/dbt_linreg"
    version: "0.2.6"