Refactor dwarfWalker::findValue #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function always returns 'true' and few callsites checked the bool out variable. Using an optional here makes everything simpler. Logging has been substantially improved for better tracing.
hainest
added
code cleanup
|
https://bottle.cs.wisc.edu/search?dyninst_branch=PR1160 No new regressions. |
kupsch
approved these changes
Nov 22, 2021
bbiiggppiigg
pushed a commit
to bbiiggppiigg/dyninst
that referenced
this pull request
Dec 7, 2021
This function always returns 'true' and few callsites checked the bool out variable. Using an optional here makes everything simpler. Logging has been substantially improved for better tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function always returns 'true' and few callsites checked the bool
out variable. Using an optional here makes everything simpler. Logging
has been substantially improved for better tracing. The function was
renamed to better indicate its behavior.