Docker: don't use autamus cache #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
reviewed
Apr 27, 2022
| @@ -75,13 +75,6 @@ WORKDIR /opt | |||
| RUN git clone --depth 1 https://github.com/spack/spack | |||
| ENV PATH=/opt/spack/bin:$PATH | |||
|
|
|||
| # Use the autamus build cache for faster install | |||
| # Note that autamus currently uses 18.04 | |||
| RUN python3 -m pip install botocore boto3 && \ | |||
There was a problem hiding this comment.
This looks good, but there could be cases in the future (if you are using spack in the container) that you'd still hit a bug not having boto3 and botocore. E.g., the regular spack binary cache requires it, regardless of autamus. So my suggestion is to remove adding the cache but keep the deps install.
But if you absolutely hate them, if the container builds then that is sufficient enough to not have them.
There was a problem hiding this comment.
Oh, I didn't realize that was separate. If spack can still use it, then we should keep it.
The public keys have been removed.
hainest
force-pushed
the
thaines/docker_remove_autamus_cache
branch
from
e9be5d5 to
2e5375f
Compare
wcohen
pushed a commit
to wcohen/dyninst
that referenced
this pull request
Jul 26, 2022
The public keys have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public keys have been removed.