Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev rc/v3 bug fix #785

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Dev rc/v3 bug fix #785

merged 5 commits into from
Nov 8, 2024

Conversation

remocristoforetti
Copy link
Contributor

Minor bug fixing in:

  • matRad_writeMHD
  • matRad_StfGenratorBase

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Project coverage is 49.62%. Comparing base (f45b593) to head (2cd7f30).
Report is 1 commits behind head on rc/v3.

Files with missing lines Patch % Lines
matRad/IO/matRad_readMHD.m 0.00% 6 Missing ⚠️
matRad/IO/matRad_writeMHA.m 25.00% 6 Missing ⚠️
matRad/IO/matRad_writeMHD.m 33.33% 4 Missing ⚠️
matRad/IO/matRad_writeVTK.m 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            rc/v3     #785      +/-   ##
==========================================
- Coverage   50.23%   49.62%   -0.62%     
==========================================
  Files         598      598              
  Lines       37186    37212      +26     
==========================================
- Hits        18682    18466     -216     
- Misses      18504    18746     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it. Not entirely sure about the axis permutation fix, as it also needs to be seen in the bigger context of the writeCube function. Please make sure that this is consistent with what would be imported in another platform (e.g. 3D Slicer or MITK) and that the reimport in matRad works out (maybe the tests don't cover this situation yet).

@wahln wahln merged commit 18380b4 into e0404:rc/v3 Nov 8, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants