Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ora in eslint-plugin-file-progress #72

Closed
43081j opened this issue Aug 8, 2024 · 4 comments
Closed

Replace ora in eslint-plugin-file-progress #72

43081j opened this issue Aug 8, 2024 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@43081j
Copy link
Collaborator

43081j commented Aug 8, 2024

We can replace ora with an alternative (see #71)

current npmgraph:
https://npmgraph.js.org/?q=eslint-plugin-file-progress

current size: 580K

you also have the opportunity to replace chalk with picocolors while you're in there (or in a separate PR) and reduce the footprint even further (plus improve perf)

@43081j 43081j added the help wanted Extra attention is needed label Aug 8, 2024
@babs20
Copy link

babs20 commented Aug 11, 2024

I am going to put in a PR for this shortly. Removing chalk and ora in favor of picocolors and nanospinner.

@babs20
Copy link

babs20 commented Aug 11, 2024

PR Here

@43081j
Copy link
Collaborator Author

43081j commented Aug 11, 2024

great work 🥳

let me know if/when they merge and we can close this

@babs20
Copy link

babs20 commented Aug 12, 2024

this has been merged!

@43081j 43081j closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants