Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ora in electron/rebuild #73

Open
43081j opened this issue Aug 8, 2024 · 3 comments
Open

Replace ora in electron/rebuild #73

43081j opened this issue Aug 8, 2024 · 3 comments
Labels
rejected Changes to this package were rejected by the repo maintainer. Maybe try again later

Comments

@43081j
Copy link
Collaborator

43081j commented Aug 8, 2024

We can replace ora with a lighter alternative (see #71 )

Current npmgraph:
https://npmgraph.js.org/?q=@electron/rebuild

We can also replace chalk (in a separate PR if needed), with picocolors.

Usage of ora:
https://github.com/electron/rebuild/blob/f5872bb88e8cf9299d7f22e6f6d9d71ff089f76c/src/cli.ts#L103
@43081j 43081j added the help wanted Extra attention is needed label Aug 8, 2024
@Namchee
Copy link

Namchee commented Aug 12, 2024

Tracked in electron/rebuild#1148

@Namchee
Copy link

Namchee commented Aug 13, 2024

Seems like it got declined.

@43081j
Copy link
Collaborator Author

43081j commented Aug 13, 2024

We can revisit it at a later time. Many large projects use picocolors, so it may be that a standalone pr is more likely one day

@Fuzzyma Fuzzyma added rejected Changes to this package were rejected by the repo maintainer. Maybe try again later and removed help wanted Extra attention is needed labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rejected Changes to this package were rejected by the repo maintainer. Maybe try again later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fuzzyma @43081j @Namchee