Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating-label: explore/implement markup restructuring for autofill reactivity #2078

Closed
ArtBlue opened this issue Jun 5, 2023 · 0 comments
Closed

Comments

@ArtBlue
Copy link
Contributor

ArtBlue commented Jun 5, 2023

In some browsers, autofill tends to conflict with the floating label. For this issue, explore ways to restructure the markup and use :autofill selector to handle these conflicting use cases:

image

Note

Some background from Ian regarding a fix on the ebay ui side...

There is a known issue with chrome and autofill. To get around it we have to check for the change in background color:

https://stackoverflow.com/questions/35049555/chrome-autofill-autocomplete-no-value-for-password/35783761#35783761

Its possible Chrome may have added a new colour, in which case we need to update our code here:

https://github.com/makeup/makeup-js/blob/master/packages/makeup-floating-label/index.js#LL61C1-L61C1

Floating label code is referenced here in coreUI:
https://github.com/eBay/ebayui-core/blob/master/src/components/ebay-textbox/component-browser.js#L36

@LuLaValva LuLaValva linked a pull request Jun 6, 2023 that will close this issue
9 tasks
@agliga agliga added this to the 16.2.x milestone Jul 26, 2023
@agliga agliga closed this as completed Jul 26, 2023
@agliga agliga added this to eBayUI Jul 26, 2023
@agliga agliga moved this to Done in eBayUI Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants