Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEK: update color value #2245

Closed
agliga opened this issue Jan 10, 2024 · 0 comments
Closed

EEK: update color value #2245

agliga opened this issue Jan 10, 2024 · 0 comments
Assignees
@agliga
Labels
module: eek-badge type: bug
Milestone
17.1.0

Comments

@agliga
Copy link
Contributor

agliga commented Jan 10, 2024

One of the hex values used for the EEK icons doesn’t meet the value in the European regulations and is leading to a mismatch
https://github.com/eBay/skin/blob/master/src/less/eek/eek.less you can see that the value for color-2 is #adbd38 when it should be #4dbd38, #4dbd38 is what is in the European regulations and what we’re seeing being returned from official sources.
@agliga agliga added this to the 17.1.0 milestone Jan 10, 2024
@agliga agliga self-assigned this Jan 10, 2024
@agliga agliga added this to eBayUI Jan 10, 2024
@agliga agliga moved this to In Progress in eBayUI Jan 12, 2024
@agliga agliga moved this from In Progress to Pull request in eBayUI Jan 12, 2024
@agliga agliga mentioned this issue Jan 12, 2024
Merged
9 tasks
@agliga agliga moved this from Pull request to Done in eBayUI Jan 17, 2024
@agliga agliga moved this to Done in eBayUI Jan 19, 2024
@agliga agliga moved this from Pull request to Done in eBayUI Jan 19, 2024
@agliga agliga closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agliga agliga

Labels
module: eek-badge type: bug
Projects
eBayUI
Status: Done
Milestone
17.1.0
Development

No branches or pull requests
1 participant
@agliga