Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress-stepper: Fails contrast for the grey line on white background #2494

Closed
1 task done
saiponnada opened this issue Nov 13, 2024 · 4 comments
Closed
1 task done
Assignees
Milestone

Comments

@saiponnada
Copy link
Contributor

saiponnada commented Nov 13, 2024

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

image

https://webaim.org/resources/contrastchecker/?fcolor=C7C7C7&bcolor=FFFFFF

Expected behavior

The contrast of the incomplete tracking steps against the white background has a contrast of at least 3.0:1

@saiponnada
Copy link
Contributor Author

Pending appropriate color token from Design team.

@randybascue
Copy link

randybascue commented Nov 19, 2024

color-foreground-secondary is the value to use

@saiponnada
Copy link
Contributor Author

Pending final approval from design on what color to use(--color-neutral-500 vs --color-neutral-600). And weather to apply only on ring vs hr before the ring

@ArtBlue ArtBlue modified the milestones: 18.5.0, 18.6.0 Nov 22, 2024
@saiponnada
Copy link
Contributor Author

Discussed with @randybascue, We decided to only update the progress stepper ring color(use --color-stroke-default aka --color-neutral-500) for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants