Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

250127 - Avatar Component - Enhancement #2539

Closed
3 tasks done
ratinsl opened this issue Jan 27, 2025 · 0 comments
Closed
3 tasks done

250127 - Avatar Component - Enhancement #2539

ratinsl opened this issue Jan 27, 2025 · 0 comments
Assignees
Labels
design system Requested by the design system size: 2 type: enhancement
Milestone

Comments

@ratinsl
Copy link

ratinsl commented Jan 27, 2025

Description

We have a couple of specs for the avatar that we'd like to get updated to align with enhanced DS Avatar guidance:

[Custom/Image avatar scrim]
We noticed our custom/image avatar does not have our radial image scrim applied to it by default. We'd like to add this to match how we treat images on item tiles across the site to help maintain a clear visual outline, even when extreme or unexpected cropping occurs or when a white background is used.

[Custom/Image avatar cropping behavior]
We also have new image sizing behavior to help enhance image cropping within the avatar component:

  1. - Image cropping (square and 4:3)
  • Square, 4:3, and aspect ratios in between are set to "fill." These dimensions allow images to fully occupy the avatar’s shape with minimal cropping of the original content.

2. Image cropping (below 4:3)

  • Crops narrower than a 4:3 aspect ratio, such as 16:9 or more extreme formats, are adjusted to “fit.” This ensures that logos and other important areas of an image are not inadvertently cut off.

[Default avatar text centering]
The letters inside of the colorful default avatar look to be ever-so-slightly higher than optical center of the circle. It may be because of the baseline of Market sans. Can we adjust this to achieve "optical vertical center"?

If you have any questions, please let us know!

Best,
Ryan

Screenshots

Image Image Image Image

Figma link

No response

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@agliga agliga added this to eBayUI Jan 31, 2025
@agliga agliga self-assigned this Jan 31, 2025
@agliga agliga added this to the 19.1.0 milestone Jan 31, 2025
@agliga agliga added size: 2 design system Requested by the design system and removed needs triage labels Jan 31, 2025
@agliga agliga moved this to Todo in eBayUI Jan 31, 2025
@agliga agliga moved this from Todo to In Progress in eBayUI Feb 4, 2025
@agliga agliga moved this from In Progress to Pull request in eBayUI Feb 10, 2025
@agliga agliga moved this from Pull request to Done in eBayUI Feb 12, 2025
@agliga agliga closed this as completed by moving to Done in eBayUI Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design system Requested by the design system size: 2 type: enhancement
Projects
Status: Done
Development

No branches or pull requests

2 participants