Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens: Incorrect color values #2545

Closed
3 tasks done
randybascue opened this issue Jan 30, 2025 · 0 comments
Closed
3 tasks done

Tokens: Incorrect color values #2545

randybascue opened this issue Jan 30, 2025 · 0 comments
Assignees
@ArtBlue
Labels
design system Requested by the design system size: 1 type: enhancement
Milestone
19.1.0

Comments

@randybascue
Copy link

randybascue commented Jan 30, 2025 •
edited
Loading

Description

A few of the color tokens are incorrect. Primarily the stroke-attention values

Incorrect

--color-stroke-attention: var(--color-red-500);

Corrected

--color-stroke-attention: var(--color-red-600);

Screenshots

No response

Figma link

No response

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@agliga agliga added this to eBayUI Jan 31, 2025
@agliga agliga added this to the 19.1.0 milestone Jan 31, 2025
@agliga agliga added size: 1 design system Requested by the design system labels Jan 31, 2025
@agliga agliga moved this to Todo in eBayUI Jan 31, 2025
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Feb 5, 2025
@ArtBlue ArtBlue mentioned this issue Feb 5, 2025
Merged
9 tasks
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Feb 5, 2025
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Feb 6, 2025
@ArtBlue ArtBlue closed this as completed by moving to Done in eBayUI Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtBlue ArtBlue

Labels
design system Requested by the design system size: 1 type: enhancement
Projects
eBayUI
Status: Done
Milestone
19.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/2545-tokens-incorrect-color-values eBay/skin
3 participants
@ArtBlue @agliga @randybascue