Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Notice - Inline Notice: Add With Dismiss #2548

Open
1 of 8 tasks
kcarboy opened this issue Jan 31, 2025 · 1 comment
Open
1 of 8 tasks

Alert Notice - Inline Notice: Add With Dismiss #2548

kcarboy opened this issue Jan 31, 2025 · 1 comment
Labels
blocked: design design system Requested by the design system type: bug

Comments

@kcarboy
Copy link

kcarboy commented Jan 31, 2025

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Skin and UI Core do not have “With Dismiss” version to Inline Notice.

Expected behavior

Skin and UI Core should have “With Dismiss” version to Inline Notice.

Skin version

No response

Device/OS/Browser info

No response

Steps to reproduce

1.
2.
3.
...

Relevant code block

No response

Additional context

Description

Similar to Page Notice and Section Notice, add a “With Dismiss” version to Inline Notice. This is needed in both Skin and UI Core.

Relevant links:

https://opensource.ebay.com/skin/component/inline-notice/
See “Dismiss” section in Playbook: https://playbook.ebay.com/design-system/components/inline-notice#properties

Checklist

  • Engineering pre-requisites
  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@agliga
Copy link
Contributor

agliga commented Jan 31, 2025

Before we take this up, we would like to have all the variations of notices aligned.
This way we can basically consoliadate most of the notice code and figure out what parts are not needed and clean it up that way.

@agliga agliga added the design system Requested by the design system label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: design design system Requested by the design system type: bug
Projects
Status: No status
Development

No branches or pull requests

2 participants