Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility function that retrieves the package versions #466

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

BSchilperoort
Copy link
Member

Closes #465

How to use:

>>> from ewatercycle.util import get_package_versions
>>> get_package_versions

{
    'ewatercycle': '2.3.1',
    'grpc4bmi': '0.5.0',
    'ewatercycle_hype': '0.0.1',
    'ewatercycle_HBV': '1.8.5',
    'ewatercycle_wflow': '0.0.2',
    'ewatercycle_marrmot': '0.0.2',
    'ewatercycle_lisflood': '0.0.1',
    'ewatercycle_pcrglobwb': '0.0.2'
}

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.32%. Comparing base (224383d) to head (a55a594).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ewatercycle/util.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   79.29%   79.32%   +0.02%     
==========================================
  Files          28       28              
  Lines        1850     1862      +12     
  Branches      155      155              
==========================================
+ Hits         1467     1477      +10     
- Misses        325      327       +2     
  Partials       58       58              
Files with missing lines Coverage Δ
src/ewatercycle/util.py 85.15% <83.33%> (-0.19%) ⬇️

Copy link
Contributor

@RolfHut RolfHut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why the test failed: it looks good to me. Do you see why it failed @BSchilperoort ? If you also think it looks ok, I will approve and merge.

@BSchilperoort
Copy link
Member Author

I don't see why the test failed: it looks good to me. Do you see why it failed @BSchilperoort ? If you also think it looks ok, I will approve and merge.

An import in the test .py file was in the wrong order. I fixed it now.

Copy link
Contributor

@RolfHut RolfHut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now

@RolfHut RolfHut merged commit 258cd7f into main Nov 14, 2024
6 checks passed
@BSchilperoort BSchilperoort deleted the version-util branch November 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Util function to print out ewatercycle+dependency+model versions
2 participants