Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{devel}[system/system] ReFrame v4.2.0 #17873

Merged

Conversation

akesandgren
Copy link
Contributor

(created using eb --new-pr)

@akesandgren akesandgren added this to the 4.x milestone May 8, 2023
@akesandgren
Copy link
Contributor Author

Do we need #13844 to be sorted out, or is that mote now?

@smoors
Copy link
Contributor

smoors commented May 12, 2023

Do we need #13844 to be sorted out, or is that mote now?

IIU @boegel C this is no longer be needed for EESSI (or will no longer be in the near future)

@boegel
Copy link
Member

boegel commented May 17, 2023

I think injecting the -S is still needed to avoid surprises in certain environments (and the downsides should be very limited).

@akesandgren
Copy link
Contributor Author

@boegel can you provide a change then?

@smoors
Copy link
Contributor

smoors commented May 23, 2023

@akesandgren he's saying that you don't need to change anything :)

@smoors
Copy link
Contributor

smoors commented May 23, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=17873 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17873 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10848

Test results coming soon (I hope)...

- notification for comment with ID 1559502252 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/08e9a8036d46468ada17207a92110908 for a full test report.

@smoors
Copy link
Contributor

smoors commented May 23, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17873 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17873 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2653

Test results coming soon (I hope)...

- notification for comment with ID 1559517237 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/849120ab8926cd6a82576b9e5db2f8df for a full test report.

@smoors smoors modified the milestones: 4.x, next release (4.7.2) May 23, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented May 23, 2023

Going in, thanks @akesandgren!

@smoors smoors merged commit 75dd363 into easybuilders:develop May 23, 2023
@akesandgren akesandgren deleted the 20230508082337_new_pr_ReFrame420 branch May 24, 2023 05:38
@casparvl
Copy link
Contributor

Since I get test failures in #18320 (essentially: a one line change, that should only influence the generated modulefile), let me double check what happens on the tests if I run them here...

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=17873 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17873 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11262

Test results coming soon (I hope)...

- notification for comment with ID 1640333720 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e40965a7778ad1692be6a77c4390cb40 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants