-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel}[system/system] ReFrame v4.2.0 #17873
{devel}[system/system] ReFrame v4.2.0 #17873
Conversation
Do we need #13844 to be sorted out, or is that mote now? |
I think injecting the |
@boegel can you provide a change then? |
@akesandgren he's saying that you don't need to change anything :) |
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1559502252 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 |
@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1559517237 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @akesandgren! |
Since I get test failures in #18320 (essentially: a one line change, that should only influence the generated modulefile), let me double check what happens on the tests if I run them here... |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1640333720 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
(created using
eb --new-pr
)