Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chem} [foss/2023a + intel/2023a] QuantumESPRESSO 7.3.1 with cmake #20138

Merged
merged 15 commits into from
Jul 17, 2024

Conversation

Crivella
Copy link
Contributor

@Crivella Crivella commented Mar 18, 2024

These are the easyconfigs for QE 7.3.1

@Crivella
Copy link
Contributor Author

Crivella commented Mar 18, 2024

One thing that should be tested on multiple architecture for the intel version is running with only 1 core.
In my case i was getting segmentation faults due to the implementation of OFI, which i was able to solve by setting I_MPI_FABRICS=shm from the default (on my system) tcp:ofi

shm should run on intra-node jobs only and while i think that using tcp fabric with mpirun -n 1 is not the best usecase, it is still possible that users will run an heavy multinode calculation followed by many single core postprocessing in the same job, so I believe this is a problem worth investigating further

@casparvl
Copy link
Contributor

@ocaisa is this one you can also review, since you're also looking into #20105 ?

@Micket Micket added the update label Mar 21, 2024
@Crivella
Copy link
Contributor Author

On a side node also working on a fix to make OpenMP work, was able to have it link to fftw3f_omp and fftw3f want to check if QE should also be able to link with fftw3_mpi

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in the logs that the configure is picking up on pkgconf from the host

@ocaisa
Copy link
Member

ocaisa commented Jun 13, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20138 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4374

Test results coming soon (I hope)...

- notification for comment with ID 2165819894 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/45d2431b0dd3a9c10ee5b088413b9004 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20138 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20138 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13736

Test results coming soon (I hope)...

- notification for comment with ID 2167681542 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 14, 2024
@easybuilders easybuilders deleted a comment from Crivella Jun 14, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9db68d665f5aa946f06020ab8e0781a8 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Jul 16, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20138 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4563

Test results coming soon (I hope)...

- notification for comment with ID 2230959399 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member

ocaisa commented Jul 16, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20138 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20138 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13927

Test results coming soon (I hope)...

- notification for comment with ID 2231053278 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/c22e69d14b9eb5458442b659a2e12686 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2d468ac383c15a7098fc17777d0df8df for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented Jul 17, 2024

Closing and reopening to trigger tests

@ocaisa ocaisa closed this Jul 17, 2024
@ocaisa ocaisa reopened this Jul 17, 2024
@ocaisa ocaisa merged commit dbdaacc into easybuilders:develop Jul 17, 2024
12 of 18 checks passed
@Crivella Crivella deleted the feature-QE-7.3.1_cmake branch July 17, 2024 12:48
@boegel boegel modified the milestones: 4.x, release after 4.9.2 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants