Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walking skeleton pulling strategies #11017

Closed
benoitf opened this issue Aug 31, 2018 · 5 comments
Closed

Walking skeleton pulling strategies #11017

benoitf opened this issue Aug 31, 2018 · 5 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 31, 2018

Description

I noticed that with the sample workspace skeleton, the wsskeleton/che-hello is always pulled
image

here is a run 10mn after
image

while Theia image is loaded from the cache (already present on the machine)
both of them are described in plug-ins

Reproduction Steps

Create a workspace with workspace.next plug-ins

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Aug 31, 2018
@l0rd l0rd mentioned this issue Aug 31, 2018
57 tasks
@benoitf benoitf changed the title Improve naming for wsnext tooling containers Walking skeleton pulling strategies Sep 3, 2018
@benoitf
Copy link
Contributor Author

benoitf commented Sep 3, 2018

related to #11030

@garagatyi
Copy link

I investigated this issue and found out:

  • we do not set explicitly pull policy
  • if pull policy is not set and image tag is latest: OS uses default policy Always
  • if pull policy is not set and image tag is not latest, e.g. nightly: OS uses default policy IfNotPresent

So we need to explicitly set pull policy in sidecar containers to Always

@benoitf
Copy link
Contributor Author

benoitf commented Sep 3, 2018

Can it be a parameter ? instead of Always so I can tweak it do IfNotPresent on demand

When I try locally ws.next if I download each image at each workspace restart I have to wait a very long time with my internet connection.

@garagatyi
Copy link

@benoitf sure

@mshaposhnik
Copy link
Contributor

Done in #11536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

4 participants