Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che plugin broker should support ephemeral mode #11554

Closed
l0rd opened this issue Oct 9, 2018 · 7 comments
Closed

Che plugin broker should support ephemeral mode #11554

l0rd opened this issue Oct 9, 2018 · 7 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 9, 2018

Description

It is now possible to configure workspace to run in ephemeral mode (i.e. PVs will be of type EmptyDir) setting persistVolumes attribute to false.

"attributes": {
  "persistVolumes": "false"
}

But Che 7 plugin brokers are still started with PVCs (broker-config-volume and claim-che-workspace). Can we fix that?

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. team/osio labels Oct 9, 2018
@l0rd l0rd mentioned this issue Oct 9, 2018
57 tasks
@garagatyi
Copy link

@l0rd Since broker is running in a pod separate from workspace pods how would we deliver plugins into the workspace? Looks like we would need to redesign the flow to achieve this. WDYT?

@l0rd
Copy link
Contributor Author

l0rd commented Oct 9, 2018

@garagatyi yes. That's what I am worried about. But in the new theia-plugin-broker we should not need to deliver plugins anymore don't we?

@garagatyi
Copy link

Actually, we need it. Theia reads metadata from the plugins package.json files.

@garagatyi
Copy link

@benoitf could you comment whether I am correct.

@amisevsk
Copy link
Contributor

From a brief look at this yesterday, one issue that has to be addressed before anything else is #11653.

Apart from that, it seems like the task of getting the plugin broker to work with ephemeral workspaces will be rather difficult; since the broker runs separate from the workspace pod, it's impossible to share storage between the two at the moment. After discussion with @garagatyi I've got a few leads and will work towards a proof-of-concept PR to see if we can implement this.

@amisevsk
Copy link
Contributor

Opened PR #11657 to address #11653.

@garagatyi
Copy link

@amisevsk can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants