-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che plugin broker should support ephemeral mode #11554
Comments
@l0rd Since broker is running in a pod separate from workspace pods how would we deliver plugins into the workspace? Looks like we would need to redesign the flow to achieve this. WDYT? |
@garagatyi yes. That's what I am worried about. But in the new theia-plugin-broker we should not need to deliver plugins anymore don't we? |
Actually, we need it. Theia reads metadata from the plugins |
@benoitf could you comment whether I am correct. |
From a brief look at this yesterday, one issue that has to be addressed before anything else is #11653. Apart from that, it seems like the task of getting the plugin broker to work with ephemeral workspaces will be rather difficult; since the broker runs separate from the workspace pod, it's impossible to share storage between the two at the moment. After discussion with @garagatyi I've got a few leads and will work towards a proof-of-concept PR to see if we can implement this. |
@amisevsk can we close this issue? |
Description
It is now possible to configure workspace to run in ephemeral mode (i.e. PVs will be of type
EmptyDir
) settingpersistVolumes
attribute to false.But Che 7 plugin brokers are still started with PVCs (
broker-config-volume
andclaim-che-workspace
). Can we fix that?The text was updated successfully, but these errors were encountered: