Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT Proxy do not redirect websocket requests if token/cookie is missing #12575

Closed
garagatyi opened this issue Feb 1, 2019 · 1 comment
Closed

JWT Proxy do not redirect websocket requests if token/cookie is missing #12575

garagatyi opened this issue Feb 1, 2019 · 1 comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@garagatyi
Copy link

Description

When some code tries to access a secure server using websocket connection but token/cookie is missing JWT proxy redirects it to http(s) page. Since websocket URL would not allow setting cookie on loader.js side we should just forbid such a case.
@garagatyi garagatyi added kind/bug Outline of a bug - must adhere to the bug report template. team/platform labels Feb 1, 2019
@skabashnyuk skabashnyuk added the severity/P2 Has a minor but important impact to the usage or development of the system. label Mar 6, 2019
@garagatyi garagatyi mentioned this issue Mar 27, 2019
Closed
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skabashnyuk @garagatyi @che-bot