Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to define runtime configuration for editors/plugins in Che 7? #13157

Closed
makandre opened this issue Apr 15, 2019 · 7 comments
Closed

How to define runtime configuration for editors/plugins in Che 7? #13157

makandre opened this issue Apr 15, 2019 · 7 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@makandre
Copy link

Description

How do you define runtime env-vars, configuration and/or preferences to be passed to editor/plugins that are started via workspace configuration attributes? i.e.

"attributes": {
    "editor": "org.eclipse.che.editor.theia:1.0.0",
    "plugins": "che-machine-exec-plugin:0.0.1"
}

Reproduction Steps

OS and version:

Diagnostics:

@monaka monaka added the kind/question Questions that haven't been identified as being feature requests or bugs. label Apr 16, 2019
@garagatyi
Copy link

Unfortunately, we can't override it at the moment. See #12981 where we discuss a possibility to override RAM limit. And my comment to make it also possible to override all the other parts in the same way as mem limit.

@garagatyi
Copy link

@l0rd @slemeur we need to proceed with the @gorkem 's issue on overriding configuration of a plugin. WDYT about suggested ways?

@l0rd
Copy link
Contributor

l0rd commented Apr 16, 2019

@makandre can you provide a description of your use case? What do you need the env variables for?

I think it's a good point but I am wondering why we haven't considered that before.

@makandre
Copy link
Author

My specific use case was I was creating my own welcome page plugin for the Che Theia editor, but the default Che welcome page was still showing up. So I asked in eclipse-che/che-theia#95 if there was some way to disable/hide/exclude the default welcome plugin, and one of the suggestion was I could set some env variable. Hence I wanted to see how I can pass the variable to the editor

I asked the question more generally for editor and plugins because I'm thinking there may be similar use cases.

@l0rd
Copy link
Contributor

l0rd commented Apr 16, 2019

@makandre that's a good question and thanks for asking. Your use case is a valid one and we will need to implement a way to set env variables for sidecars in the workspace definition. Probably we won't be able to include it in Che 7 GA.

Of course there are at least a couple of workaround you could use now (create your own image FROM eclipse/che-theia:next or publish your own che-theia che-plugin.yaml) but these are not straightforward.

@makandre
Copy link
Author

@l0rd I also came across this issue https://github.com/eclipse/che-theia/issues/159 which seems related.

@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2019
@che-bot che-bot closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants