Fix samples endpoint issues

[l0rd]

Is your enhancement related to a problem? Please describe

For some of the samples projects in the devfile registry, the preview URL proposed by Theia port plugin is not the correct application URL. Even if the workspace sample starts properly users won't be able to open the application in the preview panel. That's definitely a bad UX.

Describe the solution you'd like

The short term solution is to:

• identify the samples that have this problem
• fix the samples (and fork them if needed)

The long term solution is to add a new previewURL attribute to the devfiles commands #13945

[ibuziuk]

@l0rd if you do not mind I will put this issue to the End Game Plan as a subtask for Need to make sure that all devfiles from registry work on che.openshift.io

[l0rd]

@ibuziuk of course that's perfect.

One thing though: this can also be a multi-team effort as it has been the case for #13529 (comment). You coordinate that but others teams can help as well. I think it worked pretty well for #13529

[amisevsk]

From what I've seen, the current endpoint issues are:

• NodeJS + Mongo is a backend app, hard to interact with in browser: nodejs-mongo devfile sample issues #14009
  • e.g. navigating to /api/user requires an authorization token
• PHP-MySQL: Application serves app at /crud-php/public, opening the endpoint (to /) gives just a directory structure
• PHP Simple: Same as above; opens to "Index of /" page. Need to navigate to /php-web-simple to get actual app.

[amisevsk]

I've opened PR eclipse-che/che-devfile-registry#77 to work around the php devfile issues. The NodeJS + Mongo devfile is (I think) just a bad sample application; it's hard to interact with a REST backend from the browser.

[ibuziuk]

@slemeur @l0rd, in general, I believe we need to reconsider the samples we are using and get rid of / deprecate https://github.com/che-samples . IMO we should use vendor samples for all the devfiles like https://github.com/spring-projects/spring-petclinic

[ibuziuk]

Closing:

• preview url should be soon supported in devfile
• samples should be k8s based samples (samples should be kube-native for Eclipse Che )