Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che Server http sessions leak #14599

Closed
4 of 23 tasks
skabashnyuk opened this issue Sep 19, 2019 · 2 comments
Closed
4 of 23 tasks

Che Server http sessions leak #14599

skabashnyuk opened this issue Sep 19, 2019 · 2 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

Describe the bug

During my test #13034
64536243-0bf8ab00-d319-11e9-9a3f-ae83bac5001f
I've noticed that if we are not using browser client as we do for brockers, chectl, etc we
create an individual http session on tomcat side that may because of memory leak.
The goal of this task is to use a single http session after we identified the actual user. We can reuse parts of Codenvy SSO code to do that.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

multiple requests like curl http://localhost/api/user with keycloak token.

Expected behavior

Tomcat will use the same http session for all request processing.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@skabashnyuk skabashnyuk added kind/bug Outline of a bug - must adhere to the bug report template. team/platform labels Sep 19, 2019
@skabashnyuk skabashnyuk added this to the 7.3.0 milestone Sep 19, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Sep 19, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.3.0, 7.4.0 Sep 26, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.4.0, Backlog - Platform Oct 10, 2019
@skabashnyuk
Copy link
Contributor Author

skabashnyuk commented Oct 11, 2019

Знімок екрана  о 11 52 59

13 http sessions just to open one workspace

@mshaposhnik
Copy link
Contributor

Merged in #15000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants