Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace name had disappeared from command prefix in task popup #14862

Closed
4 of 23 tasks
dmytro-ndp opened this issue Oct 11, 2019 · 8 comments
Closed
4 of 23 tasks

Namespace name had disappeared from command prefix in task popup #14862

dmytro-ndp opened this issue Oct 11, 2019 · 8 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dmytro-ndp
Copy link
Contributor

Describe the bug

Happy path tests are permanently failing on step "Validation of workspace build and run", for example:
https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/che-regular-tests/view/K8S/job/Single-Che-master-check-E2E-Happy-path-tests-against-k8s/2355/console

  Validation of workspace build and run
        ▼ TopMenu.selectOption "Terminal"
        ▼ TopMenu.clickOnTopMenuButton "Terminal"
        ▼ Ide.closeAllNotifications
        ▼ TopMenu.clickOnSubmenuItem "Run Task..."
        ▼ QuickOpenContainer.waitContainer
        ▼ QuickOpenContainer.clickOnContainerItem "che: build-file-output"
        ▼ QuickOpenContainer.waitContainer
    1) Build application


  8 passing (11m)
  1 pending
  1 failing

  1) Validation of workspace build and run
       Build application:
     TimeoutError: Waiting for element to be located By(xpath, //div[@class='quick-open-entry']//span[text()='che: build-file-output'])
Wait timed out after 300009ms

screenshot-Build_application (1)

Screencast

https://youtu.be/2Vy1SMSeg5I

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Happy path tests scenario.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube 1.1.1
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Installation method

  • chectl:next
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: CRW CCI
@dmytro-ndp dmytro-ndp added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. team/che-qe labels Oct 11, 2019
@Ohrimenko1988
Copy link
Contributor

Commands display without namespaces.
And in the locator which uses in the test command names expected with namespaces.
doesn't work:
//div[@class='quick-open-entry']//span[text()='che: build-file-output']
works:
//div[@class='quick-open-entry']//span[text()='build-file-output']

@dmytro-ndp
Copy link
Contributor Author

dmytro-ndp commented Oct 14, 2019

@Ohrimenko1988: thank you for explanation.

@benoitf, @azatsarynnyy: could you, please, take a look at screenshot in description of issue: there was che: namespace name in command prefix disappeared in task popup on Friday Oct 11.
Do you happened to know if it was expected changes?

@dmytro-ndp dmytro-ndp changed the title Happy path tests failed on validation of workspace build and run Namespace name had disappeared from command prefix in task popup Oct 14, 2019
@dmytro-ndp dmytro-ndp added area/editor/theia Issues related to the che-theia IDE of Che and removed team/che-qe severity/P1 Has a major impact to usage or development of the system. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. labels Oct 14, 2019
@RomanNikitenko
Copy link
Member

I think it's expected behavior after merge eclipse-theia/theia#6247

@RomanNikitenko
Copy link
Member

@dmytro-ndp
Should we close the issue considering the comment above?

@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Feb 6, 2020
@azatsarynnyy
Copy link
Member

labeled as area/plugins as related to https://github.com/eclipse/che-theia/tree/master/plugins/task-plugin

@dmytro-ndp
Copy link
Contributor Author

@RomanNikitenko: IMO it's unexpected result of changes eclipse-theia/theia#6247

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Feb 6, 2020

@dmytro-ndp
fyi: eclipse-theia/theia#6247 (comment)

So, according to the comment the behavior was aligned with VS Code within the PR.

But maybe you are right if we really need to display prefix che for our tasks.
So, it's OK for me to keep the issue open to clarify the behavior we are interested.

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@che-bot che-bot closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants