Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of terminal workarounds in the "e2e" tests #15038

Closed
Ohrimenko1988 opened this issue Oct 31, 2019 · 2 comments
Closed

Get rid of terminal workarounds in the "e2e" tests #15038

Ohrimenko1988 opened this issue Oct 31, 2019 · 2 comments
Assignees
@Katka92
Labels
area/qe kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Milestone
Backlog - QE

Comments

@Ohrimenko1988
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Previously, the "Theia" had a terminal based on "canvas", it made interaction with the terminal impossible by selenium. That's why was implemented workarounds which were sending terminal output to the text file.
This problem was described in the issue #14772

Describe the solution you'd like

The issue #14772
was fixed by PR eclipse-theia/theia#6471
It makes possible switching between the terminal render types.

We should get rid of workarounds and interact with the terminal directly.
@Ohrimenko1988 Ohrimenko1988 added kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/che-qe labels Oct 31, 2019
@Ohrimenko1988 Ohrimenko1988 self-assigned this Oct 31, 2019
@rhopp rhopp added this to the Backlog - QE milestone Dec 4, 2019
@Katka92 Katka92 assigned Katka92 and unassigned Ohrimenko1988 Jan 9, 2020
@Katka92 Katka92 mentioned this issue Jan 31, 2020
Merged
@rhopp rhopp added the area/qe label May 11, 2020
@Katka92
Copy link
Contributor

Katka92 commented Jul 16, 2020

The workaround for testing build command is still present. Instead of checking the terminal, output is written to te file and the file is checked. Affected methods are Build application and Build application with changes.

@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@che-bot che-bot closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Katka92 Katka92

Labels
area/qe kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Milestone
Backlog - QE
Development

No branches or pull requests
4 participants
@rhopp @Ohrimenko1988 @Katka92 @che-bot