Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Codicons in Command Palette #15262

Closed
1 of 3 tasks
sunix opened this issue Nov 20, 2019 · 7 comments
Closed
1 of 3 tasks

Support Codicons in Command Palette #15262

sunix opened this issue Nov 20, 2019 · 7 comments
Assignees
@RomanNikitenko
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.11

Comments

@sunix
Copy link
Contributor

sunix commented Nov 20, 2019

Describe the bug

When using the openshift connector in Che, in the command palette, we see strange characters in messages like `$(plus) Provide new URL.

Selection_466

$(plus) should be a plus icon (as we can see in vscode)

Selection_470

Che version

  • latest
  • nightly
  • other: please specify
@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 20, 2019
@sunix sunix changed the title Openshift connector and Che Openshift connector and Che: $(plus) is displayed instead of a plus icon Nov 20, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 20, 2019
@benoitf
Copy link
Contributor

benoitf commented Nov 21, 2019

I think it's theia upstream issue with handling octicons

@benoitf
Copy link
Contributor

benoitf commented Nov 21, 2019

eclipse-theia/theia#5412

@tsmaeder
Copy link
Contributor

Unless this is important for release planning, we should not duplicate theia issues. Closing as duplicate.

@tsmaeder tsmaeder added the status/duplicate Issue identified as a duplicate of another issue label Nov 21, 2019
@tolusha tolusha removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 22, 2019
@slemeur
Copy link
Contributor

slemeur commented Nov 25, 2019

@tsmaeder An end-user, has no idea what theia is. If he is using Che, he is using Che and will report issue here. The fact that there is a issue on a component that is used in Che is "internal". Here you are forcing a user to track an issue on another repository, while the user will have no idea of when this will be fixed in Che.

@slemeur slemeur reopened this Nov 25, 2019
@slemeur
Copy link
Contributor

slemeur commented Nov 25, 2019

Once the issue upstream will be fixed and integrated in Che, this is an actual issue for Che and as such, should not be closed.
thanks.

@sunix sunix added status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. and removed status/duplicate Issue identified as a duplicate of another issue labels Nov 25, 2019
@azatsarynnyy azatsarynnyy mentioned this issue Nov 26, 2019
Closed
14 tasks
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 27, 2019
@benoitf benoitf added this to the Backlog - IDE 2 milestone Nov 27, 2019
@azatsarynnyy azatsarynnyy changed the title Openshift connector and Che: $(plus) is displayed instead of a plus icon Support Codeicons in Command Palette Jan 9, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Jan 9, 2020
Closed
13 tasks
@RomanNikitenko RomanNikitenko self-assigned this Jan 9, 2020
@azatsarynnyy azatsarynnyy changed the title Support Codeicons in Command Palette Support Codicons in Command Palette Jan 15, 2020
@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jan 17, 2020 •
edited by azatsarynnyy
Loading

I investigated the issue and commented the result here

We have to upgrade to the latest Monaco in order to get this support. See eclipse-theia/theia#5412 (comment)

So the issue depends on eclipse-theia/theia#6900

@azatsarynnyy azatsarynnyy mentioned this issue Feb 3, 2020
Closed
20 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Feb 19, 2020
Closed
16 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Mar 11, 2020
Closed
19 tasks
@azatsarynnyy azatsarynnyy modified the milestones: Backlog - IDE 2, 7.11 Mar 28, 2020
@azatsarynnyy
Copy link
Member

Fixed by upgrading Monaco editor upstream eclipse-theia/theia#7149
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.11
Development

No branches or pull requests
9 participants
@benoitf @sunix @azatsarynnyy @vparfonov @slemeur @tolusha @RomanNikitenko @tsmaeder @che-bot