Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-registry] Add support of the non-milicores values for the CPU Request / Limit #18488

Closed
ibuziuk opened this issue Nov 30, 2020 · 1 comment
Closed

[plugin-registry] Add support of the non-milicores values for the CPU Request / Limit #18488

ibuziuk opened this issue Nov 30, 2020 · 1 comment
Assignees
@sparkoo
Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 30, 2020

Is your enhancement related to a problem? Please describe.

Need to add support of the non-milicores values for the CPU Request / Limit e.g.

     cpuLimit: "1"
     cpuRequest: "0.03"

Currently, this fails with the schema validation exception:

The command '/bin/sh -c ./check_metas_schema.sh v3' returned a non-zero code: 1 Error: Process completed with exit code 1.

Describe the solution you'd like

Both 1000m and 1 values should be supported

Describe alternatives you've considered

Fix #18484

Additional context

See eclipse-che/che-plugin-registry#716
@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. area/plugin-registry severity/P1 Has a major impact to usage or development of the system. labels Nov 30, 2020
@ibuziuk ibuziuk mentioned this issue Nov 30, 2020
Closed
15 tasks
@sparkoo sparkoo mentioned this issue Dec 4, 2020
Merged
9 tasks
@sparkoo sparkoo self-assigned this Dec 4, 2020
@sparkoo
Copy link
Member

sparkoo commented Dec 7, 2020

fixed by eclipse-che/che-plugin-registry#741

@sparkoo sparkoo closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparkoo sparkoo

Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sparkoo @ibuziuk