github pr plugin: fork creation is hanging when creating a pull request

[sunix]

Describe the bug

Using the Github PR plugin to create a new PR, it is proposing to create a fork but is hanging at that point

Che version

• 7.22.1

Steps to reproduce

• Create a new workspace from a github project.
• add the github pr plugin in the devfile
• start/restart the workspace
• allow/signin github
• checkout a new branch
• make changes, commit
• from the github pr panel, create a new PR
• user is invited to create a fork. Accept.
• the popup hangs with the message: Creating Pull Request: Start publishing branch ...

Runtime

• kubernetes

Installation method

• chectl

Environment

• Cloud
  • Amazon
  • Azure
  • GCE
  • other (please specify)
• other: please specify

[vinokurig]

Couldn't reproduce the issue:

[sunix]

@vinokurig try to create a PR where you are not the owner :)

[sunix]

@vinokurig I am wondering if the github app we create have enough permissions:

[vinokurig]

@sunix
I don't think that the problem is in permissions, I've authenticated the plugin with hardcoded token which had repo permissions and the issue is still reproducible.

[vinokurig]

depends on #18933
I can't build my custom che-theia image with additional logging to catch the error.

[ericwill]

Removed blocked status as the blocker issue has been resolved.

[sunix]

I don't have this problem anymore !!!!
Don't know what did the fix but, this is what I have now:

And then when using the Github PR:

[vinokurig]

@sunix

I don't have this problem anymore !!!!

Ok, I'll check it on my side.

[sunix]

To test it I created that PR eclipse-che/che-theia#988

[vinokurig]

I still can reproduce it by creating a PR to https://github.com/testmagic-123/test.git

[sunix]

I have this now if I don't have permission, not sure why it is not creating a fork:

Extension-Host:Promise rejection not handled in one second: Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "PermissionDenied",
  "gitCommand": "push",
  "stdout": "",
  "stderr": "remote: Permission to testmagic-123/test.git denied to sunix.\nfatal: unable to access 'https://github.com/testmagic-123/test/': The requested URL returned error: 403\n"
} , reason: Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "PermissionDenied",
  "gitCommand": "push",
  "stdout": "",
  "stderr": "remote: Permission to testmagic-123/test.git denied to sunix.\nfatal: unable to access 'https://github.com/testmagic-123/test/': The requested URL returned error: 403\n"
}

[vinokurig]

I've tried this on the latest version of the GitHub PR plugin an the issue is NOT reproducible there. So updating to a newer version should fix the problem: #18661

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[vinokurig]

/remove-lifecycle stale