Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of yq and jq usage in the che-code entrypoint #22345

Closed
RomanNikitenko opened this issue Jul 4, 2023 · 0 comments
Closed

Get rid of yq and jq usage in the che-code entrypoint #22345

RomanNikitenko opened this issue Jul 4, 2023 · 0 comments
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jul 4, 2023

Depends on:

Is your task related to a problem? Please describe

We are going to support running VS Code in the containers that don't include the pre-requisites, see #21778.

At the moment che-code entrypoint depends on the yq and jq tools:

Describe the solution you'd like

The entrypoint should not depend on the yq and jq tools.
Actually yq is used to read /devworkspace-metadata/flattened.devworkspace.yaml file and get CHE_CODE_ENDPOINT.

I think we should have a possibility to get that endpoint as env variable without any complex logic on the entrypoint side.

@RomanNikitenko RomanNikitenko added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/vscode Issues related to the Code OSS editor of Che labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants