Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the first 'starterProject' during DevWorkspace creation from devfile.io samples / stacks #22486

Closed
Tracked by #22485
ibuziuk opened this issue Sep 6, 2023 · 3 comments
Assignees
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Sep 6, 2023

Is your task related to a problem? Please describe

Devfile.io samples could have one or multiple starterProjects defined e.g. https://registry.devfile.io/devfiles/java-vertx/1.2.0
When DevWorkspace is created based on the devfile with startedProjects defined we should use controller.devfile.io/use-starter-project attribute and reference the first starterProject defined in the devfile.

Describe the solution you'd like

Resulting DevWorkspace should have the the following attribute set:

apiVersion: workspace.devfile.io/v1alpha2
kind: DevWorkspace
spec:
  template:
    attributes:
      controller.devfile.io/use-starter-project: first-starter-project-from-devfile
    starterProjects:
      - name: first-starter-project-from-devfile
        git:
           (...)

Describe alternatives you've considered

N/A

Additional context

More details in

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Sep 6, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 6, 2023

@svor @olexii4 @akurinnoy folks, please review
I think it makes sense to add this logic to the lib we use for devfile -> dw conversion

@ibuziuk ibuziuk changed the title Use the first 'starterProject' during DevWorkspace creation from devfile.io samples / stack Use the first 'starterProject' during DevWorkspace creation from devfile.io samples / stacks Sep 6, 2023
@svor
Copy link
Contributor

svor commented Sep 6, 2023

@svor @olexii4 @akurinnoy folks, please review I think it makes sense to add this logic to the lib we use for devfile -> dw conversion

+1. We can implement it in the devworkspace generator tool.

@svor
Copy link
Contributor

svor commented Sep 21, 2023

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2023.09.21-16_59_48.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants