Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error logging on predestroy #3064

Closed
akorneta opened this issue Nov 14, 2016 · 2 comments
Closed

Add error logging on predestroy #3064

akorneta opened this issue Nov 14, 2016 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@akorneta
Copy link
Contributor

We have components that clean up after themselves on stopping of the application server. Such components can produce exceptions on predestroy phase and some of this exceptions where handled without logging by DUMMY implementation of DestroyErrorHandler, so it is therefore proposed to add logging for such cases.

@skabashnyuk skabashnyuk added kind/enhancement A feature request - must adhere to the feature request template. sprint/next status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Nov 14, 2016
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Nov 17, 2016

@akorneta can you provide examples of list of such classes?

@akorneta
Copy link
Contributor Author

@skabashnyuk I think we don't need to add logging to each class where on pre destroy an exception may occur. The main goal is to add logging in to DestroyErrorHandler for identify potentially unreliable places.

@vinokurig vinokurig self-assigned this Jan 20, 2017
@vinokurig vinokurig added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jan 20, 2017
@vinokurig vinokurig added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 1, 2017
@vinokurig vinokurig removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

4 participants