Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask user to save the command modifications on closing editor #3497

Closed
azatsarynnyy opened this issue Dec 23, 2016 · 1 comment
Closed

Ask user to save the command modifications on closing editor #3497

azatsarynnyy opened this issue Dec 23, 2016 · 1 comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Dec 23, 2016 •
edited
Loading

Reproduction Steps:

  1. Open any command in the editor
  2. Do some changes
  3. Close editor tab

Expected behavior:

User should be asked to save the command modifications.

Observed behavior:

save

Additional information:

  • branch icom
  • code that must handle such situation is already written in this method but it seems that some changes have been made in Part API and it broke the invocation of the PartPresenter#onClose method.
@azatsarynnyy azatsarynnyy added kind/bug Outline of a bug - must adhere to the bug report template. team/ide labels Dec 23, 2016
@slemeur slemeur mentioned this issue Dec 23, 2016
Closed
17 tasks
@TylerJewell
Copy link

I think having a save button could be poor UX. We do not ask users to save edits to their code files. We just auto save them. Why not the same here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerJewell @azatsarynnyy