Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate correct working xtermjs with requirejs #3517

Closed
AndrienkoAleksandr opened this issue Dec 26, 2016 · 2 comments
Closed

Investigate correct working xtermjs with requirejs #3517

AndrienkoAleksandr opened this issue Dec 26, 2016 · 2 comments
Assignees
@AndrienkoAleksandr
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@AndrienkoAleksandr
Copy link
Contributor

We did investigation usage xtermjs instead of old term.js and found technical problem: requirejs which we uses for Orion editor initialization fails xtermjs initialization, because xtermjs used node thechonlogy. Goal of this issue investigate how we can resolve this problem.

Expected behavior:

xtermjs scripts shold initalize successfull

Observed behavior:
Initalization xtermjs scrips fails.
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Dec 26, 2016
@AndrienkoAleksandr AndrienkoAleksandr changed the title Investigate correct working xtermjs with requirejs for Orion Investigate correct working xtermjs with requirejs Dec 26, 2016
@vkuznyetsov vkuznyetsov added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. kind/bug Outline of a bug - must adhere to the bug report template. labels Dec 26, 2016
@vkuznyetsov vkuznyetsov mentioned this issue Dec 26, 2016
Closed
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Dec 27, 2016
Closed
6 tasks
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. status/in-progress This issue has been taken by an engineer and is under active development. labels Dec 27, 2016
@AndrienkoAleksandr
Copy link
Contributor Author

xterm.js can works like correct requirejs module, so I find solution: inject xterm.js like requirejs module 48befcd

@TylerJewell
Copy link

Yeah! Nice work @AndrienkoAleksandr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TylerJewell @vkuznyetsov @AndrienkoAleksandr