Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Refactoring #8939

Closed
tsmaeder opened this issue Feb 27, 2018 · 2 comments
Closed

Rename Refactoring #8939

tsmaeder opened this issue Feb 27, 2018 · 2 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current

Comments

@tsmaeder
Copy link
Contributor

@gorkem will produce a PR for implementing Rename with file level operations soon, we'll need to adapt our rename UI to use that operation analogous to #6748

@tsmaeder tsmaeder added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next team/languages labels Feb 27, 2018
@tsmaeder tsmaeder mentioned this issue Feb 27, 2018
22 tasks
@tsmaeder
Copy link
Contributor Author

Update from a video conference session with @gorkem @tolusha @svor :

  • @gorkem has moved a RenameProcessor to jdt.ls (from jdt.ui) and has code that uses this to produce a "new style" WorkspaceEdit
  • @svor will take over that code, add additional rename processors to implement a custom command that can take the options we produce in the current refactoring UI and return a WorkspaceEdit
  • The curent UI will take the workspace edit to show a preview
  • We have code already that applies "old style" workspace edits, we need to extend that to be able the file level operations in new style edits
  • @tsmaeder will split this task into subtask, so we can parallelize it

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants