Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jsonbender with jsonata for transformation of json documents #272

Open
netomi opened this issue Sep 16, 2024 · 14 comments
Open

Replace jsonbender with jsonata for transformation of json documents #272

netomi opened this issue Sep 16, 2024 · 14 comments

Comments

@netomi
Copy link
Contributor

netomi commented Sep 16, 2024

Python implementation: https://pypi.org/project/jsonata-python/

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

JSONBender works great and I would like to continue using it, though the repo on GitHub has been deleted.

@mbarbero
Copy link
Contributor

Did you try to reach out to the original developer? It may be worth initiating a conversation. WDYT?

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

An option would also be to fork it ourselves.

It works great, though the choice of DSL is also a bit questionable and would be a good thing to change.

jsonata is also a good option, though JSONBender does exactly what I need and with jsonata you need to go through the hoops of writing a transformation in json and parse it later on. With JSONBender everything is in python code which is clearly an advantage.

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

I did not reach out to the original author as it was created > 10 years ago and the last release from the fork was 6 years ago, so long time dead already, no hopes of any revival.

@mbarbero
Copy link
Contributor

I did not reach out to the original author as it was created > 10 years ago and the last release from the fork was 6 years ago, so long time dead already, no hopes of any revival.

gotcha, makes sense.

An option would also be to fork it ourselves.

I think I would be less worried if we were doing that. However, I cannot find anything license information in the pypi package. Do we know the original license of the code?

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

here is a link to another still existent fork updated to the latest released version https://github.com/Formlabs/jsonbender/blob/develop/LICENSE

should be like MIT

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

the original repo does not have a LICENSE though: https://github.com/eduardostalinho/jsonbender,

actually all commits come from this developer https://github.com/etandel so that code was copied around it seems. I cant find any reference to the original code on GitHub by this user.

@mbarbero
Copy link
Contributor

From a IP perspective, it is very shady. Did it pass the EF IP review?

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

yes

@mbarbero
Copy link
Contributor

Ok, then please fork this with the license EMO has detected. Do you want to make the fork internal to otterdog, or as a separate repo in CSI?

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

hmm I want to reach out to the original author first and see what he has to say. He seems to be active just there is no trace of this project anymore from him.

@netomi
Copy link
Contributor Author

netomi commented Sep 27, 2024

looking at his linkedin profile, he worked for the company that published JSONBender to pypi. So this repo was the canonical source.

@netomi
Copy link
Contributor Author

netomi commented Oct 7, 2024

so I did not receive any answer from the original author of JSONBender on keybase.

@netomi
Copy link
Contributor Author

netomi commented Nov 14, 2024

so I am inclined to rewrite JSONBender with a DSL that would be more fitting. It should not be too hard, using jsonata feels a bit like an overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants