Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HttpUtils use in jsp #960

Closed
scottmarlow opened this issue May 5, 2022 · 2 comments
Closed

Remove HttpUtils use in jsp #960

scottmarlow opened this issue May 5, 2022 · 2 comments
Labels
10.0 Issues related to the Jakarta EE 10 Platform TCK release

Comments

@scottmarlow
Copy link
Contributor

scottmarlow commented May 5, 2022

As per https://www.eclipse.org/lists/jsp-dev/msg00303.html, resolve failure Cannot find symbol HttpUtils in basicSSL.jsp as HttpUtils is removed in Servlet 6.0.

Also remove comment reference to HttpUtils in
[implicitImportHttp.jsp](https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jsp/spec/tagfiles/directives/tag20/implicitImportHttp.jsp.

@scottmarlow scottmarlow added the 10.0 Issues related to the Jakarta EE 10 Platform TCK release label May 5, 2022
@scottmarlow
Copy link
Contributor Author

scottmarlow commented May 5, 2022

@markt-asf what does String requestURL = HttpUtils.getRequestURL( request ).toString(); need to change to in https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/integration/sec/secbasicssl/basicSSL.jsp#L53?

@markt-asf
Copy link
Contributor

You can use HttpServletRequest.getRequestURL() but looking at the test it could just use getScheme() and achieve the same result. I'll do a quick PR but note that I can't test this as I'm not set up to run the platform tests, just the individual specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.0 Issues related to the Jakarta EE 10 Platform TCK release
Projects
None yet
Development

No branches or pull requests

2 participants