Ability to inject ServletContext into Application constructor

[jerseyrobot]

Jersey runs on top of ServletContainer. We should be able to pass servlet init parameters using web.xml and read them from Application by injecting ServletContext and using ServletContext.getInitParameter(). Currently, injecting @context ServletContext into Application's constructor results in a null value.

Affected Versions

[2.4]

[jerseyrobot]

@glassfishrobot Commented
Reported by cowwoc

[jerseyrobot]

@glassfishrobot Commented
Issue-Links:
is related to
JERSEY-1950

[jerseyrobot]

@glassfishrobot Commented
@mpotociar said:
Reclassifying as bug. Spec mandates support for injection of ServletContext into JAX-RS components. (I am not 100% sure if it does not somehow exclude Application from the injectable list, but cannot see a reason why it would.)

[jerseyrobot]

@glassfishrobot Commented
cowwoc said:
This issue is loosely related to #2531. We should be able to inject values using ServletContext for both production and unit tests.

[jerseyrobot]

@glassfishrobot Commented
q3aiml said:
I notice you've already started on this so I may be late, but I was interested in seeing this fixed so I took a look a few days ago.

It seems as if this is caused by the provider of the ServletContext binding, WebComponentBinder, not taking effect until resourceConfig.configureMetaProviders. Unfortunately configureMetaProviders is called after the creation of the Application even though the registration of the binder, which seems to only stick it somewhere for holding, happens before.

A second call to configureMetaProviders before the creation of the application does fix the injection, but I don't understand the binder registration and other things well enough to know if it breaks anything else by calling it twice. Maybe if the Application tries to override some existing built-in injection? All tests as part of the normal build still pass, though.

--- a/core-server/src/main/java/org/glassfish/jersey/server/ApplicationHandler.java
+++ b/core-server/src/main/java/org/glassfish/jersey/server/ApplicationHandler.java
@@ -276,6 +276,7 @@ public final class ApplicationHandler {
         if (application instanceof ResourceConfig) {
             final ResourceConfig rc = (ResourceConfig) application;
             if (rc.getApplicationClass() != null) {
+               rc.configureMetaProviders(locator);
 rc.setApplication(createApplication(rc.getApplicationClass()));
             }
         }

I suppose similar would need to also be done for the other constructor.

[jerseyrobot]

@glassfishrobot Commented
@AdamLindenthal said:
Fixed, integration test has been added (tests/integration/jersey2184).

@q3aiml: thanks a lot, but finally I went for a different fix.

[jerseyrobot]

@glassfishrobot Commented
Marked as fixed on Thursday, December 12th 2013, 7:03:01 am

[jerseyrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JERSEY-2184

[jerseyrobot]

• Issue Imported From: https://github.com/jersey/jersey/issues/2456
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @AdamLindenthal
• Original Issue Closed By:@glassfishrobot