Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to @theia/filesystem breaks EcoreCommandContribution #56

Closed
drkstr101 opened this issue Nov 8, 2020 · 2 comments
Closed

Upgrades to @theia/filesystem breaks EcoreCommandContribution #56

drkstr101 opened this issue Nov 8, 2020 · 2 comments

Comments

@drkstr101
Copy link
Contributor

drkstr101 commented Nov 8, 2020

RE: eclipse-theia/theia#7908

Hello,

I didn't see this on the roadmap anywhere, so I thought I would open up a ticket and see if I can make some progress on it.

Goal: Support latest Theia release (1.7.0 as of now)

Problem: Updates to @theia/filesystem are incompatible with EcoreCommandContribution

Proposed Solution:

  1. Update FileStat import to the new location
  2. Replace calls to FileSystem with equiv in FileService
  3. Fix any additional type errors as needed
@drkstr101 drkstr101 changed the title Upgrades to @theia/filesystem:next breaks EcoreCommandContribution Upgrades to @theia/filesystem breaks EcoreCommandContribution Nov 8, 2020
@CamilleLetavernier
Copy link
Member

CamilleLetavernier commented Nov 9, 2020

Hi Aaron,

Ecore-GLSP follows the GLSP dependency chain, which is currently limited to Theia 1.4. In turn, GLSP depends on Sprotty, which requires the (deprecated) languages support from Theia 1.4, thus can't update to anything more recent at the moment. But there are some plans to update Sprotty in the near future, so GLSP (and then Ecore-GLSP) should be able to catch up with Theia versions.

Also, regarding Ecore-GLSP, we plan on removing all filesystem-related operations from our Theia extensions, to delegate everything to the Diagram/ModelServer (Just like it's currently done for Diagrams at the moment, i.e. relying on JSonRPC). So, all of the EcoreCommandContribution commands should disappear (eventually :) )

@drkstr101
Copy link
Contributor Author

drkstr101 commented Nov 9, 2020

Good deal! I will just close this out for now. I am slogging through language-server-extension locally, but it sounds like this will not even be needed once everything delegates to model-server. Please let me know if there is anything I can do to assist.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants