Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collision detector to work with Structured Nodes #394

Open
Tracked by #1384
CamilleLetavernier opened this issue Sep 15, 2021 · 2 comments
Open
Tracked by #1384

Improve collision detector to work with Structured Nodes #394

CamilleLetavernier opened this issue Sep 15, 2021 · 2 comments

Comments

@CamilleLetavernier
Copy link
Member

The collision detector is currently limited to detecting collisions with Sibling nodes. When using a hierarchic layout, the collision detector will provide many false-positive collisions. For example, it isn't possible to move a node inside of its parent, because child nodes always conflict with the bounds of their parent.

There is also an issue when using a shape for e.g. compartments: shrinking a node will cause a collision between the Compartment figure and its parent Node (Even though the Compartment is logically a part of the node).

In some cases, it may be tricky to distinguish the elements that should be taken into account and the ones that should be ignored (For example, child nodes that have a fixed size should be considered for collision-testing, but child nodes that can be dynamically resized - such as compartments or wrappable/truncatable labels - may be ignored)

@tortmayr
Copy link
Contributor

@planger Is this something that we should fix for the 1.0.0 release? Or are you fine with the fact that the MovmentRestrictor API can currently no be used in combination with client-side layouting?

@planger
Copy link
Member

planger commented Mar 25, 2022

As far as I understand, the movement restrictor cannot be used for hierarchical nodes, right? It still works with client-side layouting in general, right?

If yes, I'd be ok with that. I think the combination of both hierarchical nodes and movement restriction is something quite specific that typically requires customization anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants