From 11e02d25f0e40298946daccb2455a22ed7175982 Mon Sep 17 00:00:00 2001 From: Yan Zhang Date: Tue, 19 Nov 2019 14:19:10 +0800 Subject: [PATCH] assert order of quickfix/refactor/source actions Signed-off-by: Yan Zhang --- .../jdt/ls/core/internal/handlers/CodeActionHandlerTest.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java b/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java index 5a9278a0b4..05d82a62d0 100644 --- a/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java +++ b/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java @@ -20,6 +20,7 @@ import java.util.List; import java.util.Objects; import java.util.Optional; +import java.util.stream.Collectors; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.jdt.core.ICompilationUnit; @@ -231,6 +232,10 @@ public void testCodeAction_allKindsOfActions() throws Exception { assertTrue("No refactor actions were found", hasRefactor); boolean hasSource = codeActions.stream().anyMatch(codeAction -> codeAction.getRight().getKind().startsWith(CodeActionKind.Source)); assertTrue("No source actions were found", hasSource); + + List a = codeActions.stream().map(codeAction -> codeAction.getRight().getKind()).collect(Collectors.toList()); + assertTrue("quickfix actions should be ahead of refactor actions", a.lastIndexOf(CodeActionKind.QuickFix) < a.indexOf(CodeActionKind.Refactor)); + assertTrue("refactor actions should be ahead of source actions", a.lastIndexOf(CodeActionKind.Refactor) < a.indexOf(CodeActionKind.Source)); } @Test