Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature help returns wrong active parameter #1063

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Signature help returns wrong active parameter #1063

merged 1 commit into from
Jul 8, 2019

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jun 6, 2019

Fixes #1039

Signed-off-by: Snjezana Peco [email protected]

@snjeza snjeza requested review from gorkem and fbricon June 6, 2019 17:46
@fbricon
Copy link
Contributor

fbricon commented Jun 18, 2019

Doesn't seem to work for

Object foo = new Object();
System.err.println(foo);

Screen Shot 2019-06-18 at 7 23 00 PM

@fbricon
Copy link
Contributor

fbricon commented Jun 18, 2019

Another case that doesn't work (cursor on 1st param):
Screen Shot 2019-06-18 at 7 26 56 PM

@snjeza snjeza mentioned this pull request Jul 1, 2019
Closed
@snjeza
Copy link
Contributor Author

snjeza commented Jul 1, 2019

@fbricon I have updated the PR.

@fbricon fbricon merged commit 234ebc8 into eclipse-jdtls:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature help returns wrong active parameter
2 participants
@snjeza @fbricon