ConfigurationServiceImpl creates duplicate instances

[ctron]

On startup the Kura ConfigurationServiceImpl does re-create all factory configurations. This results in duplicate service instances. Adding one more for each start.

The reason why this does not manifest into a problem is that Kura forces Equinox to clear the configuration area when starting up.

However this makes the OSGi ConfigAdmin effectively non-persistent and doesn't allow any non-Kura configuration to be stored. It also does not work on Karaf.

[cdealti]

@ctron it might be temporarily fixed by checking the Equinox clean start property and avoiding updating the configurations read from the snapshot 0. For some historical reasons (corruption of the OSGi storage are) at Eurotech, clean start has always been the choice for embedded systems.
Things may have changed and we should verify if this is till the case.

[cdealti]

I've decided to give this a try [1].
The ConfigurationService implementation determines if the configuration area is available by looking for a kura.config.dirty property which it sets through the ConfigurationAdmin.
If the configuration area is clean it will load the configuration from the snapshot file.

To experiment with this branch, the osgi.clean property must be set to false. Alternatively, the directory specifying the configuration are must be deleted before Kura is started.

I've noticed a weird behavior in the emulator. Some components are weirdly activated, updated or deactivated (concurrently?) at a very early stage:

2018-12-18T14:29:31,930 [Start Level: Equinox Container: c582d4c8-4595-4678-8db9-dece1d090c20] INFO  o.e.k.c.d.H2DbServiceImpl - activating...
2018-12-18T14:29:31,931 [Start Level: Equinox Container: c582d4c8-4595-4678-8db9-dece1d090c20] INFO  o.e.k.c.d.H2DbServiceImpl - activating...done
2018-12-18T14:29:31,931 [pool-4-thread-1] INFO  o.e.k.c.d.H2DbServiceImpl - updating...
2018-12-18T14:29:31,932 [Start Level: Equinox Container: c582d4c8-4595-4678-8db9-dece1d090c20] INFO  o.e.k.c.d.H2DbServiceImpl - deactivate...
2018-12-18T14:29:32,081 [pool-4-thread-1] INFO  o.e.k.c.d.H2DbServiceImpl - Opening database with url: jdbc:h2:mem:kuradb
2018-12-18T14:29:32,173 [pool-4-thread-1] INFO  o.e.k.c.d.H2DbServiceImpl - updating...done
2018-12-18T14:29:32,173 [Start Level: Equinox Container: c582d4c8-4595-4678-8db9-dece1d090c20] INFO  o.e.k.c.d.H2DbServiceImpl - deactivate...done

I've not yet understood how to get the Felix SCR logs...

[1] https://github.com/cdealti/kura/tree/configuration-area-persisted

[MMaiero]

Worked a little bit more on this and came up with this branch: https://github.com/eclipse/kura/tree/configService_osgi-clean-false
It seems to be working, but needs more testing

[github-actions]

This issue is stale because it has been open for 60 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.