Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up static initialization around "modem" functionality #654

Closed
ctron opened this issue Oct 19, 2016 · 2 comments
Closed

Clean up static initialization around "modem" functionality #654

ctron opened this issue Oct 19, 2016 · 2 comments

Comments

@ctron
Copy link
Contributor

ctron commented Oct 19, 2016

Currently the initialization of the whole "modem" functionality is a cascade of static initialization blocks which, IMHO, has to be cleaned up.

SupportedUsbModemsInfo.java : triggers -> SupportedUsbModems

  • No real difference to SupportedUsbModems

SupportedUsbModems: triggers -> SupportedUsbModemInfo

  • depends on "lsusb", fails if this is not present
  • iterates through a

SupportedUsbModemInfo: triggers -> UsbModemDriver

  • Is a hardcoded list of modems

UsbModemDriver triggers -> ModemDriver

ModemDriver:

  • depends on a system property target.name and fails with an NPE if it is not set
  • has another hardcoded list of modems
  • it has a big static list of devices in its static init block, which cannot be extended in any way
  • every method has several switch blocks for different modem types
@MMaiero MMaiero added this to the KURA-2.2.0 milestone Nov 2, 2016
@MMaiero MMaiero removed this from the KURA-3.0.0 milestone Apr 24, 2017
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Nov 13, 2023
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants