Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview] icon of webview should be change when it appears on the left or right #5722

Closed
kpge opened this issue Jul 16, 2019 · 3 comments · Fixed by #5723
Closed

[webview] icon of webview should be change when it appears on the left or right #5722

kpge opened this issue Jul 16, 2019 · 3 comments · Fixed by #5723
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@kpge
Copy link
Contributor

kpge commented Jul 16, 2019

Description

I think the size of webview icon has two problems:

Reproduction Steps

  • install cat coding plugin in the plugin folder
  • start theia
  • open cat coding
  • move the webview widget to left panel or right panel

OS and Theia version:

Diagnostics:

@kpge
Copy link
Contributor Author

kpge commented Jul 16, 2019

@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews help wanted issues meant to be picked up, require help labels Jul 16, 2019
@akosyakov
Copy link
Member

@kpge these icons are generated dynamically from plugin metadata, they cannot be defined in css. Generally you should be able to use css variables in dynamic rules as well.

@kpge
Copy link
Contributor Author

kpge commented Jul 16, 2019

@akosyakov I know icon path is defined in the metadata, so background-image should be generated dynamically, but the default variables can be defined in the css file. I will send a PR, and move the default definition to css file. If they can't be move, I will change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants