Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quick-open] Apply dynamic quick pick items #5814

Closed
vinokurig opened this issue Jul 30, 2019 · 3 comments
Closed

[quick-open] Apply dynamic quick pick items #5814

vinokurig opened this issue Jul 30, 2019 · 3 comments
Labels
menus issues related to the menu todo larger scoped issues vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jul 30, 2019 •
edited
Loading

Description

The quick-pick menu must support dynamic items. Need to implement quick-pick onDidChangeValue emitter to be able to handle the input value and dynamically update quick pick items according to the input value.
Can be tested against: https://github.com/microsoft/vscode-extension-samples/tree/master/quickinput-sample: F1 => Quick Input Samples => quickOpen

Depends on #5187

Reproduction Steps

OS and Theia version:

Diagnostics:
@vinokurig vinokurig added todo larger scoped issues menus issues related to the menu labels Jul 30, 2019
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Jul 30, 2019
@vince-fugnitto
Copy link
Member

FYI, the link provided is broken https://github.com/Microsoft/vscode-extension-samples/tree/master/quickinput-samples

@vinokurig
Copy link
Contributor Author

@vince-fugnitto Fixed the link

@vinokurig vinokurig mentioned this issue Aug 2, 2019
Merged
@vinokurig
Copy link
Contributor Author

Is fixed by #5187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
menus issues related to the menu todo larger scoped issues vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @vinokurig @vince-fugnitto