Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fs-watcher] not support soft link watch #5968

Closed
502647092 opened this issue Aug 17, 2019 · 3 comments
Closed

[fs-watcher] not support soft link watch #5968

502647092 opened this issue Aug 17, 2019 · 3 comments
Labels
file-watchers issues related to filesystem watchers - nsfw filesystem issues related to the filesystem

Comments

@502647092
Copy link
Contributor

Description

fs-watcher not support soft link watch

Reproduction Steps

temp

OS and Theia version:
git-commit: 9105c43

Diagnostics:

@akosyakov akosyakov added the filesystem issues related to the filesystem label Aug 17, 2019
@akosyakov
Copy link
Member

Unfortunately nsfw reports an event only for one symlink, not all :( We've decided to resolve all symlinks to real paths: #2566 (comment) It covers most of the cases. But obviously we cannot report for all symlinks, since we don't have such information. Also see Axosoft/nsfw#30, implementing it via indexing all symlinks will harm performance

@akosyakov
Copy link
Member

As an idea we could try to preserver an information whether the given file node is a symlink or not and to which realpath and refresh it as well when an event is reported. I remember trying something like that but it would fix an issue only for the navigator and design was quite impactful to apis.

@havogt
Copy link

havogt commented Feb 5, 2020

I probably encountered this bug with a gitpod setup. I didn't want to enforce .theia/settings.json for the non-gitpod users, so I decided to put the .theia folder in a subdirectory and create a symlink on gitpod init. The effect is that in the debug view, the launch selector doesn't get updated if a new configuration is added to the launch.json file.
Here is an example setup to reproduce: https://github.com/havogt/gitpod-playground.
Not high priority for me, as I solved the problem with hard links.

@tsmaeder tsmaeder added the file-watchers issues related to filesystem watchers - nsfw label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-watchers issues related to filesystem watchers - nsfw filesystem issues related to the filesystem
Projects
None yet
Development

No branches or pull requests

4 participants