Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugAdapterTracker-onDidSendMessage(): theia sends string, vscode sends object #7470

Closed
tomcec opened this issue Apr 1, 2020 · 3 comments · Fixed by #7517
Closed

DebugAdapterTracker-onDidSendMessage(): theia sends string, vscode sends object #7470

tomcec opened this issue Apr 1, 2020 · 3 comments · Fixed by #7517
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@tomcec
Copy link

tomcec commented Apr 1, 2020

Description

It seems that theia sends string to method onDidSendMessage() in DebugAdapterTracker comparing to vscode that sends object.

Reproduction Steps

Debug onDidSendMessage() implementation of DebugAdapterTracker in theia and in vscode.

OS and Theia version:
OS: ubuntu wsl 18.04 in windows 10
Theia version: @theia/example-browser 0.16.0

Diagnostics:
Theia sends json string, vscode sends json object.

@akosyakov akosyakov added bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Apr 1, 2020
@dsseng
Copy link
Contributor

dsseng commented Apr 8, 2020

@tomascechatbroadcomcom what did cause this issue and what was the fault? Could you please tell what extension failed and what errors were printed or any other wrong behaviour?

@ishche
Copy link
Contributor

ishche commented Apr 8, 2020

@tomascechatbroadcomcom what did cause this issue and what was the fault? Could you please tell what extension failed and what errors were printed or any other wrong behaviour?

I've updated my sample extension: https://github.com/ishche/vscode-samples-extension/releases/tag/0.0.2 or https://marketplace.visualstudio.com/items?itemName=x0a.vscode-samples-extension

Steps to reproduce:

  1. Run the command: "Example: Track DAP message"
  2. Start any debug session
    Expected: Info message with Type: object
    Actual: Info message with Type: string

@dsseng
Copy link
Contributor

dsseng commented Apr 8, 2020

Thank you! Will test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants