Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@types/node" dependency not aligned with Node V12 version #8555

Closed
STDeslandes opened this issue Sep 24, 2020 · 4 comments · Fixed by #8556
Closed

"@types/node" dependency not aligned with Node V12 version #8555

STDeslandes opened this issue Sep 24, 2020 · 4 comments · Fixed by #8556
Labels
dependencies pull requests that update a dependency file

Comments

@STDeslandes
Copy link

STDeslandes commented Sep 24, 2020

Bug Description:

The "@types/node" dependency is not aligned with node version.
In fact I want to use worker_threads feature available in node V12 and import is not working due to this issue

Steps to Reproduce:

  1. add import { Worker } from 'worker_threads'; in any file of an extension
  2. see that 'worker_threads' definition is not available

Additional Information

  • Operating System: Windows
  • Theia Version: 0.0.0
@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Sep 24, 2020
@vince-fugnitto
Copy link
Member

Just to mention, the typings are only useful when developing for this repository.
The typings do not affect downstream applications or extensions.

@STDeslandes
Copy link
Author

Just to mention, the typings are only useful when developing for this repository.
The typings do not affect downstream applications or extensions.

I m developing my extension in the "packages" folder.

@vince-fugnitto
Copy link
Member

Just to mention, the typings are only useful when developing for this repository.
The typings do not affect downstream applications or extensions.

I m developing my extension in the "packages" folder.

Will the extension be upstreamed as part of a pull-request for this repo?
If not, this should not be the approach when developing custom extensions for your application.

@STDeslandes
Copy link
Author

Just to mention, the typings are only useful when developing for this repository.
The typings do not affect downstream applications or extensions.

I m developing my extension in the "packages" folder.

Will the extension be upstreamed as part of a pull-request for this repo?
If not, this should not be the approach when developing custom extensions for your application.

I agree. I'm more testing possibilities and performances right now. But you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants