Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Versioning of the APIs of the BPN Discovery Services #43

Merged
merged 4 commits into from
Oct 10, 2023
Merged

feat:Versioning of the APIs of the BPN Discovery Services #43

merged 4 commits into from
Oct 10, 2023

Conversation

shijinrajbosch
Copy link
Contributor

@shijinrajbosch shijinrajbosch commented Sep 7, 2023 •
edited
Loading

Description

Introduced versioning of the APIs of the BPN Discovery Services

  • Introduced versioning of the APIs of the BPN Discovery Services.
  • First version of this API is 1.0.

tunacicek
tunacicek approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek
Copy link
Contributor

@shijinrajbosch : Please adjust changelog with new version.

@tunacicek
Copy link
Contributor

@shijinrajbosch Please adjust changelog.md with new version.

@shijinrajbosch
Copy link
Contributor Author

@shijinrajbosch Please adjust changelog.md with new version.

Thanks for the review comments @tunacicek , I have updated the changelog accordingly.

agg3fe
agg3fe reviewed Oct 10, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

agg3fe
agg3fe approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agg3fe agg3fe merged commit 6970721 into eclipse-tractusx:main Oct 10, 2023
@shijinrajbosch shijinrajbosch changed the title feat:Versioning of the APIs of the Discovery Services feat:Versioning of the APIs of the BPN Discovery Services Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunacicek tunacicek tunacicek approved these changes

@agg3fe agg3fe agg3fe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shijinrajbosch @tunacicek @agg3fe