Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): adjust seeding data #56

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat(framework): adjust seeding data #56

merged 1 commit into from
Sep 25, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 13, 2024

Description

  • remove unsupported framework credentials
  • add DataExchangeGovernanceCredential Framework

Why

To only have the supported frameworks in the registry

Issue

Refs: #3

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 added this to the Release 24.12 milestone Sep 13, 2024
evegufy
evegufy previously approved these changes Sep 19, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* remove unsupported framework credentials
* add DataExchangeGovernanceCredential Framework

Refs: #3
Copy link

@Phil91 Phil91 requested a review from evegufy September 24, 2024 07:14
@Phil91 Phil91 merged commit dd74f2c into main Sep 25, 2024
10 checks passed
@Phil91 Phil91 deleted the feature/3-framework branch September 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants