Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubmodelController is unprotected #845

Closed
1 task
hgo-ds opened this issue Apr 11, 2024 · 3 comments
Closed
1 task

SubmodelController is unprotected #845

hgo-ds opened this issue Apr 11, 2024 · 3 comments
Labels
backend Backend related issues bug Something isn't working

Comments

@hgo-ds
Copy link

hgo-ds commented Apr 11, 2024

Description

Current behavior

All endpoints of

are unprotected.

Expected behavior

  • Remove unprotected API endpoint

Steps to reproduce the Bug

@github-project-automation github-project-automation bot moved this to inbox in Trace-X Apr 11, 2024
@jzbmw jzbmw added the bug Something isn't working label Apr 11, 2024
@jzbmw
Copy link
Contributor

jzbmw commented Apr 11, 2024

Open Meeting Discussion 11.04.24: Integration Test were failing because this Endpoint was open to public.
TX-is whitelisted in Spring.

@jzbmw jzbmw added the backend Backend related issues label Apr 11, 2024
@hgo-ds
Copy link
Author

hgo-ds commented Apr 11, 2024

Open Meeting Discussion 11.04.24: Integration Test were failing because this Endpoint was open to public. TX-is whitelisted in Spring.

To give some more clarification on this topic:

The integration tests of ImportControllerIT:

  • givenValidFile_whenPublishData_thenStatusShouldChangeToInPublishedToCX
  • givenValidFile2_whenPublishData_thenStatusShouldChangeToPublishedToCx
  • givenValidFile_whenPublishDataFailsOnDtr_thenStatusShouldChangeError

are failing, if the endpoints of SubmodelController are closed by some authentication method.

@mkanal mkanal moved this from inbox to backlog in Trace-X Jun 17, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 21, 2024

@hgo-ds will be fixed with #786

@mkanal mkanal closed this as completed Jun 21, 2024
@mkanal mkanal moved this from backlog to done in Trace-X Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues bug Something isn't working
Projects
Status: done
Development

No branches or pull requests

3 participants